-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize: throw Exception when no index in the table #1530
Conversation
rm-datasource/src/main/java/io/seata/rm/datasource/sql/struct/TableMetaCache.java
Outdated
Show resolved
Hide resolved
rm-datasource/src/main/java/io/seata/rm/datasource/sql/struct/TableMetaCacheOracle.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## develop #1530 +/- ##
=============================================
+ Coverage 46.43% 46.44% +0.01%
- Complexity 1691 1692 +1
=============================================
Files 347 347
Lines 12713 12717 +4
Branches 1588 1590 +2
=============================================
+ Hits 5903 5907 +4
+ Misses 6172 6170 -2
- Partials 638 640 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Ⅰ. Describe what this PR did
git some tips when no index in the table cause NPE in TableMetaCache.java.
Ⅱ. Does this pull request fix one issue?
#1529
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews