Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: get oracle primary index #1583

Merged
merged 5 commits into from
Sep 6, 2019
Merged

optimize: get oracle primary index #1583

merged 5 commits into from
Sep 6, 2019

Conversation

slievrly
Copy link
Member

@slievrly slievrly commented Sep 3, 2019

Signed-off-by: slievrly slievrly@163.com

Ⅰ. Describe what this PR did

optimize oracle index:

  1. "PRIMARY" is used for mysql primary indexName but not for oracle
  2. get primary index should always used the columnName,avoid to different oracle version index offset changed

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Signed-off-by: slievrly <slievrly@163.com>
@codecov-io
Copy link

codecov-io commented Sep 3, 2019

Codecov Report

Merging #1583 into develop will increase coverage by 0.03%.
The diff coverage is 0%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1583      +/-   ##
=============================================
+ Coverage      46.41%   46.45%   +0.03%     
  Complexity      1713     1713              
=============================================
  Files            350      350              
  Lines          12829    12827       -2     
  Branches        1616     1615       -1     
=============================================
+ Hits            5955     5959       +4     
+ Misses          6226     6222       -4     
+ Partials         648      646       -2
Impacted Files Coverage Δ Complexity Δ
...rm/datasource/sql/struct/TableMetaCacheOracle.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...server/store/file/FileTransactionStoreManager.java 47.38% <0%> (+1.39%) 19% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c7df96...e11deee. Read the comment docs.

Copy link
Contributor

@l81893521 l81893521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@zjinlei zjinlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zjinlei zjinlei merged commit 7696cd8 into apache:develop Sep 6, 2019
@wangliang181230 wangliang181230 added this to the 0.8.1 milestone Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants