-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize: branch transaction repeated reporting false #1633
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/ggndnn/seata/blob/14c9f3a33474e246bb6662d06441c87f613978e7/rm-datasource/src/main/java/io/seata/rm/datasource/ConnectionProxy.java#L224 if this line throw SQLException will duplicate report?
Codecov Report
@@ Coverage Diff @@
## develop #1633 +/- ##
=============================================
- Coverage 47.39% 47.38% -0.02%
- Complexity 1777 1778 +1
=============================================
Files 362 362
Lines 13151 13153 +2
Branches 1626 1627 +1
=============================================
- Hits 6233 6232 -1
- Misses 6245 6247 +2
- Partials 673 674 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It’s my fault, LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
UT is passed.
Ⅰ. Describe what this PR did
Downstream processed branch status reporting, and only needs to be rollbacked local transaction when LOCK_RETRY_POLICY_BRANCH_ROLLBACK_ON_CONFLICT is false
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews