-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize: reduce unnecessary dependences in client side #1688
Conversation
It's ok to use seata-all as dependency. But if user use rm-datasource directly, some dependencies are unnecessary, which should be optional. |
Codecov Report
@@ Coverage Diff @@
## develop #1688 +/- ##
============================================
+ Coverage 52.78% 52.8% +0.01%
- Complexity 2499 2520 +21
============================================
Files 485 488 +3
Lines 15299 15341 +42
Branches 1754 1749 -5
============================================
+ Hits 8076 8101 +25
- Misses 6446 6466 +20
+ Partials 777 774 -3
|
70795af
to
c78b76e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
please resolve conflicts |
985e5cd
to
68df9fe
Compare
68df9fe
to
0db4b70
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
There are some unnecessary transitive dependencies of client side artifacts, e.g. rm-datasource, that may lead to dependent artifact conflict in user's environment.
This PR tried to remove unnecessary transitive dependencies of client side artifacts from pom.xml as much as possible.
Please have a review to check whether these changes are appropriate.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews