-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize:inner class may be static #1706
optimize:inner class may be static #1706
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1706 +/- ##
=============================================
- Coverage 48.69% 48.67% -0.03%
Complexity 1858 1858
=============================================
Files 365 365
Lines 13249 13249
Branches 1639 1639
=============================================
- Hits 6452 6449 -3
- Misses 6127 6129 +2
- Partials 670 671 +1
Continue to review full report at Codecov.
|
@cmonkey Thanks for your work,but these modifications may not be required so far. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
* 'develop' of https://github.com/seata/seata: test: enhance test coverage of seata common (apache#1755) security: upgrade jackson to avoid security vulnerabilities (apache#1756) bugfix:rm channel register null resource (apache#1401) bugfix:fix memory lock is not released due to hash conflict (apache#1751) optimize:use raw types instead of boxing types (apache#1747) change get charset (apache#1707) fix undo support oracle table meta cache (apache#1749) bugfix: fix use 'in' and 'between' in where condition for Oracle and Mysql (apache#1699) optimize:add some server's jvm parameters (apache#1738) Saga implementation base on state machine (apache#1608) optimize:inner class may be static (apache#1706) feature: retry when tm commit or rollback failed (apache#1739) optimize: abstract common undolog manager method (apache#1712) bugfix: when tm commit or rollback failed,xid need to be clean (apache#1735) optimize: eliminate the possibility of allocating too much direct memory (apache#1657) Based on Java 5 optimization (apache#1705) bugfix: oracle batch insert error (apache#1729) # Conflicts: # pom.xml
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews