-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add hessian codec for rpc Serialization #1983
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1983 +/- ##
============================================
+ Coverage 55.26% 55.3% +0.03%
- Complexity 2429 2437 +8
============================================
Files 432 434 +2
Lines 14442 14469 +27
Branches 1706 1706
============================================
+ Hits 7982 8002 +20
- Misses 5736 5743 +7
Partials 724 724
|
codec/seata-codec-hessian/src/main/java/io/seata/codec/hessian/HessianCodec.java
Outdated
Show resolved
Hide resolved
codec/seata-codec-hessian/src/main/java/io/seata/codec/hessian/HessianCodec.java
Outdated
Show resolved
Hide resolved
codec/seata-codec-hessian/src/main/java/io/seata/codec/hessian/HessianCodec.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some minor reviews.
codec/seata-codec-hessian/src/main/java/io/seata/codec/hessian/HessianCodec.java
Outdated
Show resolved
Hide resolved
codec/seata-codec-hessian/src/main/java/io/seata/codec/hessian/HessianCodec.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
add hessian codec for rpc Serialization
Ⅱ. Does this pull request fix one issue?
fixes #1982
Ⅲ. Why don't you add test cases (unit test/integration test)?
yes , I add it
Ⅳ. Describe how to verify it
test case success , and rpc success
Ⅴ. Special notes for reviews