Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add hessian codec for rpc Serialization #1983

Merged
merged 20 commits into from
Dec 10, 2019

Conversation

lovepoem
Copy link
Member

@lovepoem lovepoem commented Dec 3, 2019

Ⅰ. Describe what this PR did

add hessian codec for rpc Serialization

Ⅱ. Does this pull request fix one issue?

fixes #1982

Ⅲ. Why don't you add test cases (unit test/integration test)?

yes , I add it

Ⅳ. Describe how to verify it

test case success , and rpc success

Ⅴ. Special notes for reviews

@codecov-io
Copy link

codecov-io commented Dec 3, 2019

Codecov Report

Merging #1983 into develop will increase coverage by 0.03%.
The diff coverage is 81.48%.

Impacted file tree graph

@@             Coverage Diff              @@
##             develop   #1983      +/-   ##
============================================
+ Coverage      55.26%   55.3%   +0.03%     
- Complexity      2429    2437       +8     
============================================
  Files            432     434       +2     
  Lines          14442   14469      +27     
  Branches        1706    1706              
============================================
+ Hits            7982    8002      +20     
- Misses          5736    5743       +7     
  Partials         724     724
Impacted Files Coverage Δ Complexity Δ
.../seata/codec/hessian/HessianSerializerFactory.java 75% <75%> (ø) 3 <3> (?)
...main/java/io/seata/codec/hessian/HessianCodec.java 82.6% <82.6%> (ø) 4 <4> (?)
...server/store/file/FileTransactionStoreManager.java 56.5% <0%> (-0.96%) 29% <0%> (ø)
...ource/sql/struct/cache/AbstractTableMetaCache.java 88.23% <0%> (+2.94%) 12% <0%> (+1%) ⬆️

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some minor reviews.

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@zjinlei zjinlei added this to the 1.0 milestone Dec 8, 2019
Copy link
Member

@jsbxyyx jsbxyyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xingfudeshi xingfudeshi merged commit 82533f8 into apache:develop Dec 10, 2019
@lovepoem lovepoem deleted the hessian_serialization branch December 11, 2019 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use Hessian as the codec of RPC
5 participants