-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix:fix seata-spring-boot-starter does not work #2029
bugfix:fix seata-spring-boot-starter does not work #2029
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2029 +/- ##
=============================================
- Coverage 55.03% 54.95% -0.08%
+ Complexity 2475 2472 -3
=============================================
Files 444 444
Lines 14794 14809 +15
Branches 1746 1749 +3
=============================================
- Hits 8142 8139 -3
- Misses 5907 5920 +13
- Partials 745 750 +5
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
config/seata-config-core/src/main/java/io/seata/config/FileConfiguration.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
retry ci |
config/seata-config-core/src/main/java/io/seata/config/FileConfiguration.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
fix seata-spring-boot-starter does not work.
Ⅱ. Does this pull request fix one issue?
fixes #2027
Ⅲ. Why don't you add test cases (unit test/integration test)?
I've done integration testing.
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews