optimize: handing saga transaction timeout #2215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #2215 +/- ##
=============================================
- Coverage 53.92% 53.92% -0.01%
Complexity 2620 2620
=============================================
Files 490 490
Lines 15346 15350 +4
Branches 1751 1752 +1
=============================================
+ Hits 8276 8277 +1
- Misses 6288 6291 +3
Partials 782 782 |
zhangthen
approved these changes
Feb 7, 2020
booogu
pushed a commit
to booogu/seata
that referenced
this pull request
Feb 12, 2020
* handing saga transaction timeout * handing saga transaction timeout Co-authored-by: xingfudeshi <xingfudeshi@vip.qq.com> Co-authored-by: Xin Wang <xin.victorwang@gmail.com> Co-authored-by: zjinlei <75718677@qq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
When a transaction timeout occurs, the server will keep sending "rollback requests":
How to tell if the Saga transaction has timed out? Determine whether the time of stateMachineInstance.gmtUpdated exceeds the timeout period
Timeouts are:
* Timeout due to application crashed
* Timeout occurred due to message congestion during asynchronous execution
* Synchronous execution time is too long
* Asynchronous execution time is too long
Handing timeout:
1. When the server retries, the state machine determine whether the Saga transaction has timed out. If there is no timeout, the execution is rejected. If the timeout expires, the execution is allowed.
2. Before each service is executed, determines whether the Saga transaction has timed out. If it times out, stop execution directly and wait for the server to retry.
Ⅳ. Describe how to verify it
seata/test/src/test/java/io/seata/saga/engine/db/StateMachineDBTests.java
method testStateMachineTransTimeout and testStateMachineTransTimeoutAsync