-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: custom saga transaction recovery strategy on transaction timeout #2240
Merged
slievrly
merged 15 commits into
apache:develop
from
long187:saga_custom_trans_recovery_on_timeout
Feb 15, 2020
Merged
feature: custom saga transaction recovery strategy on transaction timeout #2240
slievrly
merged 15 commits into
apache:develop
from
long187:saga_custom_trans_recovery_on_timeout
Feb 15, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s_recovery_on_timeout
…b.com/long187/seata into saga_custom_trans_recovery_on_timeout
…b.com/long187/seata into saga_custom_trans_recovery_on_timeout
…b.com/long187/seata into saga_custom_trans_recovery_on_timeout
Codecov Report
@@ Coverage Diff @@
## develop #2240 +/- ##
=============================================
- Coverage 49.95% 49.94% -0.02%
Complexity 2660 2660
=============================================
Files 517 518 +1
Lines 17004 17011 +7
Branches 2021 2022 +1
=============================================
+ Hits 8495 8496 +1
- Misses 7679 7684 +5
- Partials 830 831 +1
|
slievrly
approved these changes
Feb 14, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
zhangthen
approved these changes
Feb 14, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
Feature: Custom saga transaction recovery strategy on transaction time out
In some business scenarios, rollback cannot be performed (for example, there is no compensation service configured, or the data modified), We can execute the state machine forward to complete the business process.
The default timeout transaction recovery policy of Seata server is "rollback". When the user configures the transaction recovery policy as "forward" on the state machine definition, Seata server sends a commit retry request to saga client for retry.
Ⅳ. Describe how to verify it
configure "RecoverStrategy" as "Forward" on state machine definition:
Junit tests at:
seata/test/src/test/java/io/seata/saga/engine/db/StateMachineDBTests#testStateMachineCustomRecoverStrategyOnTimeout
seata/test/src/test/java/io/seata/saga/engine/db/StateMachineDBTests#testStateMachineCustomRecoverStrategyOnTimeoutAsync