-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
codecov: codecov ignore mock #2288
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2288 +/- ##
=============================================
+ Coverage 50.12% 51.39% +1.27%
+ Complexity 2662 2661 -1
=============================================
Files 518 510 -8
Lines 17033 16604 -429
Branches 2063 2033 -30
=============================================
- Hits 8538 8534 -4
+ Misses 7687 7261 -426
- Partials 808 809 +1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/seata/seata/pull/2288/files#diff-8bc9db6adba7208e25c96be322351063L14 needs to be modified because the codec module has been renamed as serializer.
The generated codes is in target ,I think it doesn't affect coverage , but I will have a try |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
Codecov ignore mock
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
ci success
Ⅴ. Special notes for reviews