-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: insert sql primary key value support type. #2349
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2349 +/- ##
=============================================
+ Coverage 51.45% 51.52% +0.07%
- Complexity 2657 2667 +10
=============================================
Files 523 523
Lines 16940 16944 +4
Branches 2052 2053 +1
=============================================
+ Hits 8716 8731 +15
+ Misses 7393 7388 -5
+ Partials 831 825 -6
|
当values中只有一个(one), 多个(more), O表示支持 X表示不支持 第二个表,表示多个 value, null 不支持 method, null 不支持 sequence, null 不支持 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. And I believe that we could support "value" "null" "sequence" at the same time later.
Test case:
id=1
insert into account_tbl(id, user_id, money, information) values (?, ?, ?, ?)
insert into account_tbl(id, user_id, money, information) values (?, ?, ?, ?), (?, ?, ?, ?)
id=null
insert into account_tbl(id, user_id, money, information) values (?, ?, ?, ?), (?, ?, ?, ?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
insert sql primary key value support type.
Ⅱ. Does this pull request fix one issue?
fixes #2347
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews