Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: fix typo #2397

Merged
merged 1 commit into from
Mar 16, 2020
Merged

optimize: fix typo #2397

merged 1 commit into from
Mar 16, 2020

Conversation

tauntongo
Copy link
Contributor

@tauntongo tauntongo commented Mar 13, 2020

README.md has a a misspelled word-"videa"

Ⅰ. Describe what this PR did

fixed a misspelled word in README.md "videa"->"video"

Ⅱ. Does this pull request fix one issue?

No

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

README.md has a a misspelled word-"videa"
@codecov-io
Copy link

codecov-io commented Mar 13, 2020

Codecov Report

Merging #2397 into develop will increase coverage by 0.16%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2397      +/-   ##
=============================================
+ Coverage      51.87%   52.04%   +0.16%     
- Complexity      2702     2764      +62     
=============================================
  Files            517      517              
  Lines          16768    16965     +197     
  Branches        2027     2068      +41     
=============================================
+ Hits            8698     8829     +131     
- Misses          7262     7317      +55     
- Partials         808      819      +11     
Impacted Files Coverage Δ Complexity Δ
...c/main/java/io/seata/core/context/RootContext.java 36.92% <0.00%> (-3.08%) 15.00% <0.00%> (+6.00%) ⬇️
...java/io/seata/spring/tcc/TccActionInterceptor.java 10.86% <0.00%> (-2.65%) 2.00% <0.00%> (ø%)
...ing/annotation/GlobalTransactionalInterceptor.java 7.69% <0.00%> (-1.77%) 2.00% <0.00%> (ø%)
...server/store/file/FileTransactionStoreManager.java 57.14% <0.00%> (-0.32%) 30.00% <0.00%> (+1.00%) ⬇️
...java/io/seata/tm/api/GlobalTransactionContext.java 100.00% <0.00%> (ø) 12.00% <0.00%> (+6.00%)
...a/io/seata/tm/api/transaction/TransactionInfo.java 90.90% <0.00%> (+1.25%) 28.00% <0.00%> (+12.00%)
...a/io/seata/rm/datasource/exec/ExecuteTemplate.java 10.86% <0.00%> (+1.49%) 5.00% <0.00%> (+2.00%)
...r/src/main/java/io/seata/server/UUIDGenerator.java 69.04% <0.00%> (+5.71%) 8.00% <0.00%> (+3.00%)
...java/io/seata/tm/api/DefaultGlobalTransaction.java 81.81% <0.00%> (+6.02%) 37.00% <0.00%> (+15.00%)
...in/java/io/seata/tm/api/TransactionalTemplate.java 75.00% <0.00%> (+8.91%) 41.00% <0.00%> (+16.00%)

Copy link
Contributor

@zjinlei zjinlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@l81893521 l81893521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly changed the title fixed a misspelled word optimize: fix typo Mar 16, 2020
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@l81893521 l81893521 added the first-time contributor first-time contributor label Mar 16, 2020
@slievrly slievrly merged commit cf7e22c into apache:develop Mar 16, 2020
@slievrly slievrly added this to the 1.2.0 milestone Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
first-time contributor first-time contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants