Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: supplement using organization logos #2666

Merged
merged 9 commits into from
May 11, 2020

Conversation

funky-eyes
Copy link
Contributor

@funky-eyes funky-eyes commented May 8, 2020

Ⅰ. Describe what this PR did

supplement using organization logs

image

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@funky-eyes
Copy link
Contributor Author

@slievrly PTAL

@codecov-io
Copy link

codecov-io commented May 9, 2020

Codecov Report

Merging #2666 into develop will decrease coverage by 0.15%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2666      +/-   ##
=============================================
- Coverage      50.81%   50.65%   -0.16%     
+ Complexity      2814     2812       -2     
=============================================
  Files            558      558              
  Lines          17931    17912      -19     
  Branches        2126     2087      -39     
=============================================
- Hits            9111     9074      -37     
+ Misses          7953     7947       -6     
- Partials         867      891      +24     
Impacted Files Coverage Δ Complexity Δ
...obuf/convertor/BranchRegisterRequestConvertor.java 90.47% <0.00%> (-9.53%) 3.00% <0.00%> (ø%)
...otobuf/convertor/BranchReportRequestConvertor.java 90.90% <0.00%> (-9.10%) 3.00% <0.00%> (ø%)
...obuf/convertor/BranchRollbackRequestConvertor.java 92.00% <0.00%> (-8.00%) 3.00% <0.00%> (ø%)
...otobuf/convertor/GlobalBeginResponseConvertor.java 92.59% <0.00%> (-7.41%) 3.00% <0.00%> (ø%)
...otobuf/convertor/GlobalCommitRequestConvertor.java 93.75% <0.00%> (-6.25%) 3.00% <0.00%> (ø%)
...otobuf/convertor/GlobalStatusRequestConvertor.java 93.75% <0.00%> (-6.25%) 3.00% <0.00%> (ø%)
...obuf/convertor/GlobalRollbackRequestConvertor.java 93.75% <0.00%> (-6.25%) 3.00% <0.00%> (ø%)
...protobuf/convertor/RegisterTMRequestConvertor.java 94.73% <0.00%> (-5.27%) 3.00% <0.00%> (ø%)
...protobuf/convertor/RegisterRMRequestConvertor.java 90.47% <0.00%> (-4.77%) 3.00% <0.00%> (ø%)
...tobuf/convertor/BranchReportResponseConvertor.java 95.45% <0.00%> (-4.55%) 3.00% <0.00%> (ø%)
... and 20 more

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, modify the pr title.

@funky-eyes funky-eyes changed the title doc: supplement using organization logs optimize: supplement using organization logs May 9, 2020
@zjinlei zjinlei added this to the 1.3.0 milestone May 10, 2020
@funky-eyes funky-eyes changed the title optimize: supplement using organization logs doc: supplement using organization logos May 10, 2020
@funky-eyes funky-eyes closed this May 10, 2020
@funky-eyes funky-eyes reopened this May 10, 2020
Copy link
Contributor

@zjinlei zjinlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zjinlei zjinlei merged commit 834b09a into apache:develop May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants