Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: copy jdbc driver to image #2751

Merged
merged 3 commits into from
Jun 3, 2020
Merged

optimize: copy jdbc driver to image #2751

merged 3 commits into from
Jun 3, 2020

Conversation

helloworlde
Copy link
Contributor

Ⅰ. Describe what this PR did

  1. Copy jdbc driver to image

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

  1. Build an image
  2. Run container by this image
  3. Found jdbc directory under /seata-server/libs/jdbc

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented May 31, 2020

Codecov Report

Merging #2751 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #2751   +/-   ##
==========================================
  Coverage      50.89%   50.89%           
  Complexity      2849     2849           
==========================================
  Files            567      567           
  Lines          18172    18172           
  Branches        2166     2166           
==========================================
  Hits            9249     9249           
  Misses          8029     8029           
  Partials         894      894           

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@l81893521 l81893521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@l81893521 l81893521 merged commit 9ed609a into apache:develop Jun 3, 2020
@helloworlde helloworlde deleted the image branch June 3, 2020 05:51
@slievrly slievrly added this to the 1.3.0 milestone Jun 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants