-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize: no longer substring the message in rpc transmission #3201
Conversation
…_msg # Conflicts: # serializer/seata-serializer-seata/src/main/java/io/seata/serializer/seata/protocol/AbstractResultMessageCodec.java
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## develop #3201 +/- ##
=============================================
- Coverage 51.05% 50.93% -0.13%
+ Complexity 3248 3246 -2
=============================================
Files 608 608
Lines 19973 19946 -27
Branches 2494 2446 -48
=============================================
- Hits 10197 10159 -38
+ Misses 8762 8752 -10
- Partials 1014 1035 +21 |
We recommend keeping the original situation. for example: adding |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
...lizer-seata/src/main/java/io/seata/serializer/seata/protocol/AbstractResultMessageCodec.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
User Feedback: Misunderstand the message when transaction error occurred in TC. Because if the message longer than 128 byte, and TC would substring the message before rpc transmission.
no longer substring the message in rpc transmission and show the hold message especially in transaction error.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews