-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize: add options to nacos-config.py and fix some option bugs #3949
Conversation
请登记pr信息 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for @lvekee
Codecov Report
@@ Coverage Diff @@
## develop #3949 +/- ##
==========================================
Coverage 40.20% 40.20%
Complexity 3079 3079
==========================================
Files 689 689
Lines 23323 23323
Branches 2886 2886
==========================================
Hits 9376 9376
Misses 13077 13077
Partials 870 870 |
@838239178 Pls remove the irrelevant changes. |
it‘s ok now |
请修改一下pr标题,类似以下的: |
(有变更的话,在原分支上修改然后push之后就会自动被带过来的,不需要重新开一个pr) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
暂未发现相关issue
Ⅲ. Why don't you add test cases (unit test/integration test)?
已通过测试,测试范围仅包含上传config.txt到nacos中
正则表达式测试:
结果
Ⅳ. Describe how to verify it
用该脚本提交一次config.txt即可验证
Ⅴ. Special notes for reviews
上一次提交 PULL REQUEST