Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maven: fix maven-compiler-plugin and maven-resources-plugin execute failed #4700

Merged
merged 6 commits into from
Jun 17, 2022

Conversation

slievrly
Copy link
Member

@slievrly slievrly commented Jun 15, 2022

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

fix maven-compiler-plugin and maven-resources-plugin execute failed

Ⅱ. Does this pull request fix one issue?

fixes #4699 #4698

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

mvn clean install -P release-seata -DskipTests=true -X

Ⅴ. Special notes for reviews

Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
Signed-off-by: slievrly <slievrly@163.com>
…ailed

Signed-off-by: slievrly <slievrly@163.com>
…ailed

Signed-off-by: slievrly <slievrly@163.com>
@codecov-commenter
Copy link

codecov-commenter commented Jun 15, 2022

Codecov Report

Merging #4700 (0ce8761) into develop (97333ee) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #4700   +/-   ##
==========================================
  Coverage      49.28%   49.28%           
+ Complexity      4087     4086    -1     
==========================================
  Files            735      735           
  Lines          25616    25616           
  Branches        3162     3162           
==========================================
  Hits           12625    12625           
  Misses         11642    11642           
  Partials        1349     1349           

@funky-eyes funky-eyes added this to the 1.5.2 milestone Jun 15, 2022
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly merged commit 95a89d5 into apache:develop Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

maven-compiler-plugin execute failed
3 participants