optimize: require ARM64 binary #4963

odidev · 2022-09-27T10:54:09Z

Modified file  .github/workflows/test.yml, dependencies/pom.xml, discovery/seata-discovery-etcd3/pom.xml, discovery/seata-discovery-etcd3/src/test/java/io/seata/discovery/registry/etcd/EtcdRegistryServiceImplTest.java, integration/grpc/pom.xml and serializer/seata-serializer-protobuf/pom.xml for arm64 binary

Signed-off-by: odidev odidev@puresoftware.com

codecov-commenter · 2022-09-27T13:17:59Z

Codecov Report

Merging #4963 (236cdde) into develop (06c2a50) will decrease coverage by 0.50%.
The diff coverage is 46.34%.

❗ Current head 236cdde differs from pull request most recent head 3be80ae. Consider uploading reports for the commit 3be80ae to get more accurate results

@@              Coverage Diff              @@
##             develop    #4963      +/-   ##
=============================================
- Coverage      49.23%   48.72%   -0.51%     
+ Complexity      4117     4079      -38     
=============================================
  Files            737      736       -1     
  Lines          25827    25818       -9     
  Branches        3193     3184       -9     
=============================================
- Hits           12715    12579     -136     
- Misses         11764    11905     +141     
+ Partials        1348     1334      -14

Impacted Files	Coverage Δ
...c/main/java/io/seata/common/ConfigurationKeys.java	`0.00% <ø> (ø)`
...n/src/main/java/io/seata/common/DefaultValues.java	`0.00% <ø> (ø)`
...eata/common/exception/EurekaRegistryException.java	`100.00% <ø> (ø)`
...ava/io/seata/common/util/LowerCaseLinkHashMap.java	`0.00% <0.00%> (ø)`
...n/src/main/java/io/seata/common/util/PageUtil.java	`50.00% <ø> (ø)`
...ta/core/rpc/netty/AbstractNettyRemotingClient.java	`18.53% <ø> (ø)`
...n/java/io/seata/core/rpc/netty/ChannelManager.java	`0.00% <0.00%> (ø)`
.../io/seata/core/rpc/netty/NettyServerBootstrap.java	`0.00% <ø> (ø)`
...seata/core/serializer/SerializerClassRegistry.java	`0.00% <ø> (ø)`
.../io/seata/core/store/DefaultDistributedLocker.java	`0.00% <ø> (ø)`
... and 81 more

slievrly · 2022-09-27T13:33:06Z

dependencies/pom.xml

-
-        <protobuf.version>3.7.1</protobuf.version>
-        <grpc.version>1.17.1</grpc.version>
+        <protobuf-maven-plugin.version>0.6.1</protobuf-maven-plugin.version>


dependencies module should not contains plugin version, I think you should probably define it in the build module.

I have updated it in the build module as per your suggestion.

slievrly · 2022-09-27T13:40:09Z

@odidev
I think that your PR solves:

Upgrade protobuf to solve the ARM64 compatibility problem.
Check whether there is any problem on the ARM64 platform CI through Github Action Workflow.

.github/workflows/build.yml

wangliang181230 · 2022-09-27T14:05:50Z

https://docs.github.com/en/actions/hosting-your-own-runners/using-self-hosted-runners-in-a-workflow
runs-on support ARM64, is it unnecessary to use scripts to build the ARM64?

slievrly · 2022-09-27T14:06:01Z

workflow output

WARNING: The requested image's platform (linux/arm64/v8) does not match the detected host platform (linux/amd64) and no specific platform was requested

https://github.com/seata/seata/actions/runs/3135923871/jobs/5092189894

slievrly · 2022-09-29T03:48:54Z

@odidev Any responses to the questions above?

odidev · 2022-09-29T05:44:37Z

Any responses to the questions above?

@slievrly almost done, few things are left, it will take little more time. And sorry for the delay.

odidev · 2022-09-29T10:22:06Z

WARNING: The requested image's platform (linux/arm64/v8) does not match the detected host platform (linux/amd64) and no specific platform was requested

It's just a warning because, we are running an arm64 script over the amd machine using qemu.. I verified that hosted platform is also compatible for arm64 by using uname-m

odidev · 2022-10-06T05:40:16Z

@odidev Any responses to the questions above?

@slievrly I have updated all the changes as per review comments. Please have a look.

slievrly · 2022-10-09T03:31:10Z

https://docs.github.com/en/actions/hosting-your-own-runners/using-self-hosted-runners-in-a-workflow
runs-on support ARM64, is it unnecessary to use scripts to build the ARM64?

@odidev what do you think about of running on ARM64 ?

odidev · 2022-10-11T12:38:52Z

https://docs.github.com/en/actions/hosting-your-own-runners/using-self-hosted-runners-in-a-workflow
runs-on support ARM64, is it unnecessary to use scripts to build the ARM64?

@odidev what do you think about of running on ARM64 ?

@slievrly

I have built arm64-binary by using self-hosted arm64 runners which has to be hosted on arm64 machine. If it is fine, then we can get access to ARM H/W through WorksOnArm

Self-Hosted arm64 Runner in GitHub-actions:
Commit Link: odidev@85746ff

GHA Logs Link: https://github.com/odidev/seata/actions/runs/3226451554/jobs/5279982536

If you agree, I will amend the PR.

slievrly · 2022-10-12T12:01:17Z

https://docs.github.com/en/actions/hosting-your-own-runners/using-self-hosted-runners-in-a-workflow
runs-on support ARM64, is it unnecessary to use scripts to build the ARM64?

@odidev what do you think about of running on ARM64 ?

@slievrly

I have built arm64-binary by using self-hosted arm64 runners which has to be hosted on arm64 machine. If it is fine, then we can get access to ARM H/W through WorksOnArm

Self-Hosted arm64 Runner in GitHub-actions: Commit Link: odidev@85746ff

GHA Logs Link: https://github.com/odidev/seata/actions/runs/3226451554/jobs/5279982536

If you agree, I will amend the PR.

Why not just use runs-on: ARM64 ?
https://docs.github.com/en/actions/hosting-your-own-runners/using-self-hosted-runners-in-a-workflow

odidev · 2022-10-13T07:33:15Z

Why not just use runs-on: ARM64 ?

@slievrly

We can't add arm64 runner directly as arm64 runners are not supported directly for arm64.

We can use two methods for running arm64 script over an x64 machine first one is using qemu and second is self-hosted runner for arm64.

for self-hosted-runner, following are the steps.

Adding a self-hosted runner to the repository:

On GitHub.com, navigate to the main page of the repository.
Under odidev/seata, goto the Settings
In the left sidebar, click Actions, then click Runners
After that select the operating system as Linux and architecture as ARM64 for self-hosted runner machine.
Then run these commands on your local machine:
For download

$ mkdir actions-runner && cd actions-runner
$ curl -o actions-runner-linux-arm64-2.298.2.tar.gz -L https://github.com/actions/runner/releases/download/v2.298.2/actions-runner-linux-arm64-2.298.2.tar.gz
$ echo "803e4aba36484ef4f126df184220946bc151ae1bbaf2b606b6e2f2280f5042e8  actions-runner-linux-arm64-2.298.2.tar.gz" | shasum -a 256 -c
$ tar xzf ./actions-runner-linux-arm64-2.298.2.tar.gz

Configure

$ ./config.sh --url https://github.com/odidev/seata --token AJXNBROLYUMW7SXRHZKTHQDDI62UY
$ ./run.sh

After that use “runs-on: self-hosted” yaml in the workflow file for each job.

slievrly · 2022-10-18T04:40:02Z

@odidev I had some wrong understanding of this solution before, but now I have a clear understanding through github documents. I suggest using the QEMU method, but this workflow takes a long time to execute. I don't think it is suitable to put it on pull_ request. I suggest putting it into the on push branch only for execution.

odidev · 2022-10-20T06:44:43Z

@odidev I had some wrong understanding of this solution before, but now I have a clear understanding through github documents. I suggest using the QEMU method, but this workflow takes a long time to execute. I don't think it is suitable to put it on pull_ request. I suggest putting it into the on push branch only for execution.

https://docs.github.com/en/actions/hosting-your-own-runners/about-self-hosted-runners

https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners

@slievrly

It's ok to put it on a branch only for execution. Please let me know if I should commit the code to any specific branch or same branch works for you?

slievrly · 2022-10-24T13:43:07Z

@odidev I had some wrong understanding of this solution before, but now I have a clear understanding through github documents. I suggest using the QEMU method, but this workflow takes a long time to execute. I don't think it is suitable to put it on pull_ request. I suggest putting it into the on push branch only for execution.

https://docs.github.com/en/actions/hosting-your-own-runners/about-self-hosted-runners

https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners

@slievrly

It's ok to put it on a branch only for execution. Please let me know if I should commit the code to any specific branch or same branch works for you?

@odidev
I think it's enough to trigger the ARM64 compatibility check workflow when push the code into develop branch.

Signed-off-by: odidev <odidev@puresoftware.com>

odidev · 2022-11-01T11:45:20Z

@slievrly

@odidev I think it's enough to trigger the ARM64 compatibility check workflow when push the code into develop branch.

As per your suggestion, I updated the code into the on-push branch and skipped the pull_request.

slievrly

LGTM

slievrly · 2022-11-07T12:33:13Z

@odidev thanks for your contribution.

slievrly reviewed Sep 27, 2022

View reviewed changes

.github/workflows/build.yml Outdated Show resolved Hide resolved

slievrly reviewed Sep 27, 2022

View reviewed changes

.github/workflows/build.yml Show resolved Hide resolved

slievrly reviewed Sep 27, 2022

View reviewed changes

.github/workflows/build.yml Outdated Show resolved Hide resolved

Require ARM64 binary

a6eedbd

Signed-off-by: odidev <odidev@puresoftware.com>

slievrly approved these changes Nov 7, 2022

View reviewed changes

Merge branch 'develop' into arm64-binary

68be91d

slievrly added this to the 1.6.0 milestone Nov 7, 2022

slievrly added the first-time contributor first-time contributor label Nov 7, 2022

slievrly changed the title ~~Require ARM64 binary~~ optimize: require ARM64 binary Nov 7, 2022

slievrly added the image label Nov 7, 2022

slievrly merged commit 5796d64 into apache:develop Nov 7, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

optimize: require ARM64 binary #4963

optimize: require ARM64 binary #4963

odidev commented Sep 27, 2022

codecov-commenter commented Sep 27, 2022 •

edited

Loading

slievrly Sep 27, 2022

odidev Sep 29, 2022

slievrly commented Sep 27, 2022

wangliang181230 commented Sep 27, 2022

slievrly commented Sep 27, 2022

slievrly commented Sep 29, 2022

odidev commented Sep 29, 2022

odidev commented Sep 29, 2022

odidev commented Oct 6, 2022

slievrly commented Oct 9, 2022 •

edited by wangliang181230

Loading

odidev commented Oct 11, 2022

slievrly commented Oct 12, 2022 •

edited

Loading

odidev commented Oct 13, 2022

slievrly commented Oct 18, 2022 •

edited

Loading

odidev commented Oct 20, 2022

slievrly commented Oct 24, 2022 •

edited

Loading

odidev commented Nov 1, 2022

slievrly left a comment

slievrly commented Nov 7, 2022

optimize: require ARM64 binary #4963

optimize: require ARM64 binary #4963

Conversation

odidev commented Sep 27, 2022

codecov-commenter commented Sep 27, 2022 • edited Loading

Codecov Report

slievrly Sep 27, 2022

Choose a reason for hiding this comment

odidev Sep 29, 2022

Choose a reason for hiding this comment

slievrly commented Sep 27, 2022

wangliang181230 commented Sep 27, 2022

slievrly commented Sep 27, 2022

slievrly commented Sep 29, 2022

odidev commented Sep 29, 2022

odidev commented Sep 29, 2022

odidev commented Oct 6, 2022

slievrly commented Oct 9, 2022 • edited by wangliang181230 Loading

odidev commented Oct 11, 2022

slievrly commented Oct 12, 2022 • edited Loading

odidev commented Oct 13, 2022

slievrly commented Oct 18, 2022 • edited Loading

odidev commented Oct 20, 2022

slievrly commented Oct 24, 2022 • edited Loading

odidev commented Nov 1, 2022

slievrly left a comment

Choose a reason for hiding this comment

slievrly commented Nov 7, 2022

codecov-commenter commented Sep 27, 2022 •

edited

Loading

slievrly commented Oct 9, 2022 •

edited by wangliang181230

Loading

slievrly commented Oct 12, 2022 •

edited

Loading

slievrly commented Oct 18, 2022 •

edited

Loading

slievrly commented Oct 24, 2022 •

edited

Loading