New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: fix loader path in startup scripts #5010
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@neillee95 does the bat script have the same problem? |
i think so, but i have not tried |
i tried, it is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Please register the pr to develop.md https://github.com/seata/seata/tree/develop/changes
Codecov Report
@@ Coverage Diff @@
## develop #5010 +/- ##
=============================================
+ Coverage 48.81% 49.18% +0.36%
- Complexity 4079 4098 +19
=============================================
Files 733 733
Lines 25951 25958 +7
Branches 3199 3202 +3
=============================================
+ Hits 12669 12767 +98
+ Misses 11933 11833 -100
- Partials 1349 1358 +9
|
You seem to have other pr's mixed in with your code, please take them out |
|
@neillee95 please update your origin branch. |
Ⅰ. Describe what this PR did
Following this doc to deloy server directly, server startup failed with command
stack trace as following
jars in lib are not loaded by spring boot loader.
In bin/seata-server.sh, loader path is relative, it means that server must be startup under bin directory or set LOADER_PATH.
This pr replaces the relative path to absolute path.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews