Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fix loader path in startup scripts #5018

Merged
merged 6 commits into from Oct 25, 2022
Merged

bugfix: fix loader path in startup scripts #5018

merged 6 commits into from Oct 25, 2022

Conversation

neillee95
Copy link
Contributor

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

New PR which is related to #5010

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented Oct 25, 2022

Codecov Report

Merging #5018 (c3e84c3) into develop (9e6a3b5) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #5018      +/-   ##
=============================================
- Coverage      49.06%   49.04%   -0.03%     
+ Complexity      4092     4089       -3     
=============================================
  Files            733      733              
  Lines          26004    26004              
  Branches        3211     3211              
=============================================
- Hits           12759    12753       -6     
- Misses         11887    11893       +6     
  Partials        1358     1358              
Impacted Files Coverage Δ
...ava/io/seata/server/metrics/MetricsSubscriber.java 78.26% <0.00%> (-6.09%) ⬇️
...in/java/io/seata/server/session/SessionHelper.java 65.62% <0.00%> (-2.09%) ⬇️
...in/java/io/seata/server/session/GlobalSession.java 81.00% <0.00%> (-0.78%) ⬇️
...torage/file/store/FileTransactionStoreManager.java 56.91% <0.00%> (+0.64%) ⬆️
...n/src/main/java/io/seata/common/util/IdWorker.java 83.33% <0.00%> (+6.25%) ⬆️

@@ -25,6 +25,7 @@ Add changes here for all PR submitted to the develop branch.
- [[#4928](https://github.com/seata/seata/pull/4928)] fix rpcContext.getClientRMHolderMap NPE
- [[#4953](https://github.com/seata/seata/pull/4953)] fix InsertOnDuplicateUpdate bypass modify pk
- [[#4978](https://github.com/seata/seata/pull/4978)] fix kryo support circular reference
- [[#5018](https://github.com/seata/seata/pull/5018)] fix loader path in startup scripts
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

两个md的GitHub ID也登记一下

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes added this to the 1.6.0 milestone Oct 25, 2022
@funky-eyes funky-eyes added the type: bug Category issues or prs related to bug. label Oct 25, 2022
@funky-eyes funky-eyes merged commit e10e36c into apache:develop Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Category issues or prs related to bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants