bugfix: global session is always begin in saga mode for 2.x #5464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # changes/en-us/develop.md # changes/zh-cn/develop.md
slievrly
reviewed
Mar 22, 2023
done |
funky-eyes
reviewed
Mar 29, 2023
| @@ -134,6 +134,10 @@ public static void endCommitted(GlobalSession globalSession, boolean retryGlobal | |||
| MetricsPublisher.postSessionDoneEvent(globalSession, IdConstants.STATUS_VALUE_AFTER_COMMITTED_KEY, true, | |||
| beginTime, retryBranch); | |||
| } else { | |||
| if (globalSession.isSaga()) { | |||
| globalSession.setStatus(GlobalStatus.Committed); | |||
There was a problem hiding this comment.
默认的defaultcore也会调这里，也是会进行一个setstatus，不如把这行提出来，把defaultcore里的setstatus删了，这个setstatus放到if判断的前面
liuqiufeng
pushed a commit
to liuqiufeng/seata
that referenced
this pull request
Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #5045
#5050 can not fix this bug,because in saga mode,when a global transactional end , TM report the global session status to TC rather than do commit or do rollback
this pr same to pr #5145,this pr just for 2.x