bugfix: global session is not change to Committed in saga mode #5050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
funky-eyes
added
type: bug
added 3 commits
November 3, 2022 20:55
funky-eyes
reviewed
Nov 4, 2022
Codecov Report
@@ Coverage Diff @@
## develop #5050 +/- ##
=============================================
- Coverage 49.44% 49.42% -0.02%
+ Complexity 4124 4123 -1
=============================================
Files 733 733
Lines 26051 26051
Branches 3219 3219
=============================================
- Hits 12880 12876 -4
- Misses 11794 11800 +6
+ Partials 1377 1375 -2
|
|
LGTM |
caohdgege
reviewed
Nov 4, 2022
changes/zh-cn/develop.md
Outdated
| @@ -32,6 +32,7 @@ | |||
| - [[#5004](https://github.com/seata/seata/pull/5004)] 修复mysql update join行数据重复的问题 | |||
| - [[#5033](https://github.com/seata/seata/pull/5033)] 修复InsertOnDuplicateUpdate的SQL语句中无插入列字段导致的空指针问题 | |||
| - [[#5038](https://github.com/seata/seata/pull/5038)] 修复SagaAsyncThreadPoolProperties冲突问题 | |||
| - [[#5050](https://github.com/seata/seata/pull/5050)] 修复Saga模式下全局状态未正确更改成Commited | |||
caohdgege
reviewed
Nov 4, 2022
changes/en-us/develop.md
Outdated
| @@ -30,6 +30,7 @@ Add changes here for all PR submitted to the develop branch. | |||
| - [[#5004](https://github.com/seata/seata/pull/5004)] fix duplicate image row for update join | |||
| - [[#5033](https://github.com/seata/seata/pull/5033)] fix null exception when sql columns is empty for insert on duplicate | |||
| - [[#5038](https://github.com/seata/seata/pull/5038)] remove @EnableConfigurationProperties({SagaAsyncThreadPoolProperties.class}) | |||
| - [[#5050](https://github.com/seata/seata/pull/5050)] fix global session is not change to Committed | |||
caohdgege
changed the title
slievrly
reviewed
Nov 7, 2022
zw201913
pushed a commit
to zw201913/seata
that referenced
this pull request
Nov 7, 2022
* '1103' of https://github.com/zw201913/seata: optimize: remove useless code (apache#5047) bugfix: fix startup failure of Server1.5.2 by using OpenJDK 11 (apache#4874) bugfix: insert value is all parsed as string in insert on duplicate (apache#5028) bugfix: global session is not change to Committed in saga mode (apache#5050)
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
fixes #5045
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews