Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(awards): ignore null configs in awards.storage #34

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

zhammer
Copy link
Contributor

@zhammer zhammer commented Feb 28, 2024

No description provided.

Copy link
Contributor

@bbckr bbckr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, one minor comment

try {
configs[key] = storageConfig.getConfig(key);
} catch {
// config object isn't instantiated for this key
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could log here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is intended though so i don't think we need to log

@zhammer zhammer merged commit e568c37 into main Feb 28, 2024
9 checks passed
@zhammer zhammer deleted the zh-allow-null-override branch February 28, 2024 16:27
Copy link

🎉 This PR is included in version 2.0.1 🎉

The release is available on @seatgeek/backstage-plugin-awards-backend@2.0.1

Your semantic-release bot 📦🚀

Copy link

🎉 This PR is included in version 1.0.0 🎉

The release is available on @seatgeek/backstage-plugin-gitlab-catalog-backend@1.0.0

Your semantic-release bot 📦🚀

Copy link

🎉 This PR is included in version 1.0.2 🎉

The release is available on @seatgeek/backstage-plugin-slack-catalog-backend@1.0.2

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants