-
Notifications
You must be signed in to change notification settings - Fork 273
Modernize react-infinite #235
Conversation
Changes Unknown when pulling 3c366e9 on upgrades into ** on master**. |
Changes Unknown when pulling 5c6ebab on upgrades into ** on master**. |
Changes Unknown when pulling 6ee181e on upgrades into ** on master**. |
Changes Unknown when pulling b2cc7ac on upgrades into ** on master**. |
Changes Unknown when pulling 22ae28f on upgrades into ** on master**. |
Changes Unknown when pulling 3848461 on upgrades into ** on master**. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a couple comments, but these changes look great! Nice to see cypress used in production too
__tests__/infinite_test.js
Outdated
}).toThrow(); | ||
} | ||
// expect(rootNode.topSpacer._style._values.height).toEqual('400px'); | ||
// expect(rootNode.bottomSpacer._style._values.height).toEqual('1600px'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove these commented out tests if they're no longer relevant :)
__tests__/infinite_test.js
Outdated
</Infinite> | ||
); | ||
|
||
expect(rootNode).toMatchSnapshot(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not so sure that a snapshot does a better job of capturing this than explicitly looking for pointer-events
being undefined. The test's description is much more specific than the test itself
__tests__/infinite_test.js
Outdated
waitsFor(function() { | ||
return infiniteSpy.callCount > 0; | ||
}); | ||
const infiniteSpy = jasmine.createSpy('infiniteSpy'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
jasmine APIs are no longer officially supported within jest, so for future compatibility these should be replaced with jest.fn()
@@ -0,0 +1,22 @@ | |||
/* eslint-disable */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which eslint rules does this break? If it's just the cy
variable, you could drop a .eslintrc
config in the cypress directory with cy
as a global
cy.get("#infinite-example-one").as('basic'); | ||
|
||
// Shows only | ||
for (var i = 0; i < 8; i++) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let i
Changes Unknown when pulling 9549cd3 on upgrades into ** on master**. |
Changes Unknown when pulling 1596a17 on upgrades into ** on master**. |
createClass
to ES2015 classprettier
and upgradeseslint
jest
to version 20 and updates to snapshot testsflow
to version 0.52 and updates typesnode_modules
infiniteLoadBeginBottomOffset
, deprecated since 0.6.0Moving to Webpack 2 and ES2015
imports
will likely be done in a future pull request.