Skip to content
This repository has been archived by the owner on Jun 10, 2020. It is now read-only.

upgraded peer dependencies to react 16.2.0 #268

Merged
merged 2 commits into from Mar 16, 2018

Conversation

aaronincincy
Copy link

This updates peer dependencies to react 16.2.0 and fixes the failing unit tests preset in #240.

@coveralls
Copy link

coveralls commented Mar 7, 2018

Coverage Status

Coverage increased (+0.03%) to 90.741% when pulling c727ff4 on aaronincincy:upgrade-to-react-16 into 48182b4 on seatgeek:master.

@aaronincincy
Copy link
Author

I'm not sure what's going on with the failed CI build. I'll look at that when I get home this evening.

@aaronincincy
Copy link
Author

@garetht I tried to look into this, but I'm struggling to even know what the error is. Can you provide any guidance on this?

@aaronincincy aaronincincy reopened this Mar 8, 2018
@aaronincincy
Copy link
Author

Ok, I did fix an issue on the examples pages and they're now behaving the same as the current version, however I'm still getting an issue with the CI build failing. I'm not really sure where to go from here.

@mashehu
Copy link
Contributor

mashehu commented Mar 16, 2018

I think I found the problem with the build fail. It was using a deprecated version of cypress, see #269. But the test seems now to be failing because of outdated dependencies...

@garetht garetht merged commit c727ff4 into seatgeek:master Mar 16, 2018
@garetht
Copy link
Contributor

garetht commented Mar 16, 2018

Thanks for the help @aaronincincy and @mashehu! I'll make a release later today.

@aaronincincy aaronincincy deleted the upgrade-to-react-16 branch March 16, 2018 14:26
@NoelAramis
Copy link

Could you please update the @latest in the NPM repository, so that the npm install pulls the latest version from github? Thanks.

@jnarwold
Copy link

Any update on when we might get a release for this?

@schnubor
Copy link

schnubor commented Apr 3, 2018

+1 on the release? asking for a friend... ahem.

@garetht
Copy link
Contributor

garetht commented Apr 4, 2018

Sorry for the delay - will do this later today.

@garetht
Copy link
Contributor

garetht commented Apr 4, 2018

@NoelAramis @jnarwold @schnubor This has been released as 0.13.0

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants