Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove warning for integer precision loss when building on 64-bit #2

Closed
wants to merge 1 commit into from
Closed

Conversation

guykogus
Copy link

@guykogus guykogus commented Feb 8, 2017

… architecture.

@zenspider
Copy link
Member

Where are you seeing warnings? I don't get any before your patch... (I'll still apply, just curious)

@guykogus
Copy link
Author

guykogus commented Feb 9, 2017

We're using CocoaPods-Keys for an iOS project I'm working on, which is using this project for storing values in the Keychain. When that plug-in is installed for the first time those warnings come up, so I see them every time our continuous integration tasks run.

Also, I'm running macOS Sierra 10.12.3 and when I execute ruby lib/osx_keychain.rb I see those warnings as well, which was how I tested the fix.

@guykogus
Copy link
Author

guykogus commented Apr 4, 2017

@zenspider will this be merged in?

@loudmouth
Copy link

I've also been seeing the same warnings and was curious if they may be causing issues I'm having with my CI as well. I'm all for being warning free and would love to see this merged.

@zenspider
Copy link
Member

Can you please change it to match the actual type?

10061 % grep strlen /usr/include/string.h 
size_t	 strlen(const char *__s);

@guykogus
Copy link
Author

guykogus commented May 10, 2017

I'm trying to convert it away from that type, no? I'm trying to match the types used by the Security functions. E.g.

OSStatus SecKeychainAddGenericPassword(SecKeychainRef keychain, UInt32 serviceNameLength, const char *serviceName, UInt32 accountNameLength, const char *accountName, UInt32 passwordLength, const void *passwordData, SecKeychainItemRef _Nullable *itemRef);

@zenspider
Copy link
Member

Done. Thanks. Sorry I dragged my feet for so long.

@zenspider zenspider closed this Nov 30, 2017
@seattlerb seattlerb locked and limited conversation to collaborators Jan 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants