remove method "d" from global namespace #59
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruby_parser_extras defines a method "d" (which is used exactly once, in the same file) in the public namespace (main). This conflicts with Wrong's "d" method which is part of a module; for some reason even when I "include Wrong::D" the ruby_parser one is called. It's basically bad form for a gem to clutter the global namespace in any case. This patch puts it inside the (only) object where it's called.
ghost
assigned 
|
trailing whitespace... tsk tsk... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ruby_parser_extras defines a method "d" (which is used exactly once, in the same file) in the public namespace (main). This conflicts with Wrong's "d" method which is part of a module; for some reason even when I "include Wrong::D" the ruby_parser one is called. It's basically bad form for a gem to clutter the global namespace in any case.
This patch puts it inside the (only) object where it's called.