Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed github username, can't reset password #155

Closed
dreadwail opened this issue Aug 11, 2019 · 4 comments
Closed

Changed github username, can't reset password #155

dreadwail opened this issue Aug 11, 2019 · 4 comments

Comments

@dreadwail
Copy link
Contributor

dreadwail commented Aug 11, 2019

I recently changed my github username from [redacted] to dreadwail. I also don't recall my password for seattlerb.org. So I used the forgot-password feature to try and reset my password but there seems to be a bug because it refuses to save my new password because it can't process the old github username. Screenshot attached:

seattlerbfail

@dreadwail
Copy link
Contributor Author

dreadwail commented Aug 11, 2019

FYI I worked around this in the meantime by creating a [redacted] github account and then re-doing the seattlerb forgot-password dance. So this issue is just for the bug. I'd submit a PR to address it but I'm not sure what the desired functionality is: (should it legitimately fail like this when the old github name doesnt exist? Or should it permit existing accounts to re-save even if the github account does not exist?)

@zenspider
Copy link
Member

Damn good question. Looking at your data everything looks peachy now, including the new twitter/github name. Unfortunately those logs and the debugging info is looong gone. Looking at the code, and trying it out manually, your new username works fine via the github api... but I wonder if at the time it was set up as a redirect or was cached or something.

@zenspider
Copy link
Member

And yeah... PRs welcome, but no clue what you're gonna do about this one. :P

@zenspider
Copy link
Member

Things seem ok? Close?

@seattlerb seattlerb locked and limited conversation to collaborators Jan 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants