Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

https://github.com/seaweedfs/goexif: v2.0.0 must either not have go.mod file or be placed into /v2 directory #3653

Closed
kvtb opened this issue Sep 13, 2022 · 1 comment

Comments

@kvtb
Copy link
Contributor

kvtb commented Sep 13, 2022

The version tagged v2.0.0 must either not have go.mod file or be placed into /v2 directory

Currently, seaweedfs can be built only because cache on proxy.golang.org is incoherent and it cached previous version

With Google's proxy is off (GONOPROXY='*') the build fails:

# GONOPROXY='*' go mod download -x github.com/seaweedfs/goexif@v2.0.0+incompatible

go: github.com/seaweedfs/goexif@v2.0.0+incompatible: invalid version: module contains a go.mod file, so module path must match major version ("github.com/seaweedfs/goexif/v2")

The issue makes troubles with packaging seaweedfs into Linux distros which perform reproducible package builds in sandboxes without access to cache sites like proxy.golang.org

@kvtb
Copy link
Contributor Author

kvtb commented Sep 13, 2022

The commit seaweedfs/goexif@90f82ad should not add "go.mod"

chrislusf added a commit that referenced this issue Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant