-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[s3] Support ACL #4519
Comments
Similar to Iam Identity file, we store acl for buckets in the original AWS json with ACL
https://awscli.amazonaws.com/v2/documentation/api/latest/reference/s3api/put-bucket-acl.html#options First of all, I want to get Canned ACL |
Hi, I tried to refactor the PR #4090 Step 0: Passing test
Step 5: Passing tests:
|
Thanks! Maybe also write up some design doc for easier understanding. |
test_bucket_acl_default test_bucket_acl_canned_private_to_private seaweedfs#4519
|
Very happy to see this! By the way, I think there is a better way than splite ACL into several PR: Otherwise, the function of the master branch is incomplete and cannot be used, and there is no integration test. I wonder if there will be any other problems. |
This feature is a branch with 4k lines of changes and that’s not all that I would like to fix. It’s impossible to review it, not even for me. @shichanglin5 I have an important question about backward compatibility with your current installation where ACL in some form already works. Do I need to think about this? |
It would be great if it were compatible, thank you. |
optimization iam lookup for reducing algorithm complexity #4519 Co-authored-by: Konstantin Lebedev <9497591+kmlebedev@users.noreply.github.co>
…ration (#4859) * move s3account.AccountManager into to iam.S3ApiConfiguration and switch to Interface #4519 * fix: test bucket acl default and adjust the variable names * fix: s3 api config test --------- Co-authored-by: Konstantin Lebedev <9497591+kmlebedev@users.noreply.github.co> Co-authored-by: Chris Lu <chrislusf@users.noreply.github.com>
…edfs#4857) optimization iam lookup for reducing algorithm complexity seaweedfs#4519 Co-authored-by: Konstantin Lebedev <9497591+kmlebedev@users.noreply.github.co>
…ivate. (seaweedfs#4856) * Passing test: test_bucket_acl_default test_bucket_acl_canned_private_to_private seaweedfs#4519 * Update weed/s3api/s3api_bucket_handlers.go --------- Co-authored-by: Konstantin Lebedev <9497591+kmlebedev@users.noreply.github.co> Co-authored-by: Chris Lu <chrislusf@users.noreply.github.com>
… acl (seaweedfs#4858) Replace action read/write to readAcp/writeAcp for handlers with acl query seaweedfs#4519 Co-authored-by: Konstantin Lebedev <9497591+kmlebedev@users.noreply.github.co>
…ration (seaweedfs#4859) * move s3account.AccountManager into to iam.S3ApiConfiguration and switch to Interface seaweedfs#4519 * fix: test bucket acl default and adjust the variable names * fix: s3 api config test --------- Co-authored-by: Konstantin Lebedev <9497591+kmlebedev@users.noreply.github.co> Co-authored-by: Chris Lu <chrislusf@users.noreply.github.com>
Hey, folks. any updates ? |
Need to add ACL support so that s3 tests pass
and #4259
#4090
#3849
#3848
#3846
#3845
#3844
#3843
#3842
https://docs.aws.amazon.com/AmazonS3/latest/userguide/acl-overview.html
The text was updated successfully, but these errors were encountered: