Fix corrupted mount reads after changes on fh #3536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a file is opened multiple times - no matter if single- or multi- threaded - and something was written, or a metadata attribute was changed, then the following reads would always return wrong / old data until all file handles were closed and the file was reopened. The reason was that the outdated reader was not reset properly with a fresh chunk view.
|
I've confirmed that this fixes the Sonarr corruption mentioned in #2609 |
paochiang
added a commit
to paochiang/seaweedfs
that referenced
this pull request
Oct 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem are we solving?
Fix corrupted mount reads after changes on fh. See #3535.
When a file is opened multiple times - no matter if single- or multi-threaded - and something was written, or a metadata attribute was changed, then the following reads would always return wrong / old data until all file handles were closed and the file was reopened.
How are we solving the problem?
The reason was that the outdated reader was not reset properly with a fresh chunk view.
The fix is to reset the reader instance on file handles properly.
How is the PR tested?
With
dttool. See #3535.Checks