Correctly pass arangodb driver Transaction ID into the context #3586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gfxlabs
changed the title
gfxlabs
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem are we solving?
Transactions currently fail in arangodb filer store, as the underlying driver needs a context key in order for its queries to know that they should be included in the transaction. (they are performed, however they time out)
the underlying driver package does not provide a reliable method to extract the transaction id from the context, and so I am not removing the existing context key that is being added, it will be required for commit, rollback etc.
How are we solving the problem?
add the transaction id to the context using driver.WithTransactionID