New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: http rename move dir to subdir #4432

Merged

chrislusf merged 1 commit into seaweedfs:master from wusongANKANG:http_rename

Apr 27, 2023

Contributor

wusongANKANG commented Apr 26, 2023

What problem are we solving?

Http api does not prevent parent directory from moving to its subdirectory which can result in filer corruption.

refer to #4045

How are we solving the problem?

Add parent-child directory relationship judgment.

How is the PR tested?

curl -i -X POST 'http://localhost:8888/a/b/?mv.from=/a/' should be failed.

Checks

I have added unit tests if possible.
I will add related wiki document changes and link to this PR after merging.


          Fix: http rename move dir to subdir

5aed5fa

chrislusf merged commit 4867aa0 into seaweedfs:master

5 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment