fix deadlock for filer upload #4527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: wang wusong <wangwusong@virtaitech.com>
kmlebedev
pushed a commit
to kmlebedev/seaweedfs
that referenced
this pull request
Dec 22, 2023
Signed-off-by: wang wusong <wangwusong@virtaitech.com> Co-authored-by: wang wusong <wangwusong@virtaitech.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem are we solving?
fix #4526
Analysis
The main goroutine enters the loop and checks the condition atomic.LoadInt64(&bytesBufferCounter) >= 4. lf this condition is true,it waits on bytesBufferLimitCond.Wait().This will block the main goroutine until another goroutine calls bytesBufferLimitCond.Signal()
lf all the worker goroutines have finished their work and exited, there will be no more calls to "bytesBufferLimitCond.Signal().This means the main goroutine will wait indefinitely, leading to a deadlock
How are we solving the problem?
We use channels to throttle
How is the PR tested?
Checks