Fix S3 API multipart upload on Windows #4666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The file paths were being having '/' changed to '\' by filepath.Dir() resulting in a file being created with '\' separators, but when trying to read the files, the same wasn't happening.
|
Thanks! |
kmlebedev
pushed a commit
to kmlebedev/seaweedfs
that referenced
this pull request
Dec 22, 2023
The file paths were being having '/' changed to '\' by filepath.Dir() resulting in a file being created with '\' separators, but when trying to read the files, the same wasn't happening. Co-authored-by: Hendrik Appel <happel@europe.altair.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The file paths were being having '/' changed to '' by filepath.Dir() resulting in a file being created with '' separators, but when trying to read the files, the same wasn't happening.
What problem are we solving?
Failure to retrieve objects via S3 API in Windows
How are we solving the problem?
Running filepaths.ToSlash() on the result of filepath.Dir().
How is the PR tested?
Ran it and I could now retrieve objects that were created in nested dirs, e.g. /some/nested/file.txt
Checks