Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix weed fix #5020

Merged
merged 1 commit into from
Nov 20, 2023
Merged

Fix weed fix #5020

merged 1 commit into from
Nov 20, 2023

Conversation

SmsS4
Copy link
Contributor

@SmsS4 SmsS4 commented Nov 17, 2023

What problem are we solving?

#4991

How are we solving the problem?

Sorting needles by offset when mapdb wants to save idx to file

How is the PR tested?

I tested using reprod.py in issue. Also tested vacuum manually because vacuum use SaveToIdx

Checks

  • I have added unit tests if possible.
  • I will add related wiki document changes and link to this PR after merging.

@chrislusf chrislusf merged commit 6c1ce18 into seaweedfs:master Nov 20, 2023
5 checks passed
@kmlebedev kmlebedev mentioned this pull request Jan 19, 2024
Closed
@chrislusf
Copy link
Collaborator

chrislusf commented Jan 25, 2024 •
edited
Loading

reverted in cb50b72 . let's discuss in @kmlebedev 's thread.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SmsS4 @chrislusf