Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/s3 config secret #5302

Merged
merged 4 commits into from Feb 14, 2024
Merged

Conversation

spastorclovr
Copy link
Contributor

What problem are we solving?

This PR fixes couple of issues with s3 and its config as a secret :

  1. the filer statefulset would try to mount the secret even if s3 is not enabled
  2. the s3 deployment tests existingConfigSecret wrongly from .Values.filer.s3
  3. the secret could be created enven if s3 is not enabled or enableAuth is not on

How are we solving the problem?

  1. use the secret only when Values.filer.s3.enabled is on in filer-statefulset.yaml
  2. fix wrong condition to test if an existingConfigSecret is used in s3-deployment (.Values.filer.s3.existingConfigSecret vs .Values.s3.existingConfigSecret)
  3. rewrite the condtion to create the secret to make sure we check for both s3 and filer.s3 if s3 is enabled and .enableAuth is on + removed the use of skipAuthSecretCreation which is redondant with existingConfigSecret

How is the PR tested?

Manually

Checks

  • I have added unit tests if possible.
  • I will add related wiki document changes and link to this PR after merging.

@chrislusf chrislusf merged commit 3b5d8ff into seaweedfs:master Feb 14, 2024
6 checks passed
@spastorclovr
Copy link
Contributor Author

Thx for merging @chrislusf when do you think we could have it released into the helm Chart? I understand that the helm Chart is now triggered on new tag only (which is great to avoid breaking changes) 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants