Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to typography #26

Closed
3 of 4 tasks
ulde01 opened this issue Jan 21, 2019 · 3 comments
Closed
3 of 4 tasks

Updates to typography #26

ulde01 opened this issue Jan 21, 2019 · 3 comments

Comments

@ulde01
Copy link
Contributor

ulde01 commented Jan 21, 2019

Following adjustment to typography has been made 2019-01-21:

H2
weight: bold

H3
weight: bold

H6
Is no longer in use. Suggestion: make it look like H5.

New

  • Line height is specified (it was not before) for desktop, mobile and tablet
  • The biggest text size, "Display", is also available for mobile and tablet
  • "Preample" is specified (it was not before) for desktop, mobile and tablet

If you are unsure, please see the complete list of sizes and line-height for each size: http://designlibrary.sebgroup.com/visual-identity/typography/#usage (scroll down on the page)

Ask us anything (about this)!
Thank you,
Ulrika, Design management

@ulde01 ulde01 transferred this issue from seb-oss/design-library Jan 21, 2019
@hjalmers
Copy link
Contributor

hjalmers commented Jan 21, 2019

I suggest giving h6 the same appearance as h5 and encourage people not to use it if they can avoide it. It’s a standard html element so even if we ignore it browsers won’t and if some library or third party component uses it we need to style it unless we want it to look bananas:) Probably not an issue but still worth mentioning so it’s not forgotten.

@ulde01 ulde01 assigned ulde01 and unassigned ulde01 Jan 21, 2019
@ulde01 ulde01 transferred this issue from seb-oss/vanilla-pattern-library Jan 24, 2019
@ulde01 ulde01 added the developing Component is being developed label Jan 24, 2019
@ulde01 ulde01 added this to Development (see sebgroup's board) in Design discussions Jan 24, 2019
@ulde01 ulde01 added the reviewed/answered DMT reviewed or answered label Jan 30, 2019
@ulde01 ulde01 moved this from Under development to Done in Design discussions Mar 4, 2019
@ulde01 ulde01 removed developing Component is being developed reviewed/answered DMT reviewed or answered labels Mar 4, 2019
@ulde01 ulde01 closed this as completed Mar 4, 2019
@pmakro
Copy link

pmakro commented Mar 11, 2019

I would suggest making H6 at a size of 14px due to having the option of being able to differentiate between a primary and secondary headline in a supporting area/box.

By using different emphasis via typography we can introduce smaller headlines that are visible/noticeable but act more as an encapsulating headline for a paragraph rather having it the same size as regular content but in bold manner. Thus making it harder to distinguish between a headline and statement in bold in a paragraph.

See attached images for examples.

image
image

@ulde01
Copy link
Contributor Author

ulde01 commented Apr 8, 2019

@pmakro Agreed! This change is now added to the relevant frameworks, see #55

/Ulrika

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants