Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accordion should allow user to set a default active #124

Closed
DanSallau opened this issue Feb 13, 2020 · 1 comment · Fixed by #125
Closed

Accordion should allow user to set a default active #124

DanSallau opened this issue Feb 13, 2020 · 1 comment · Fixed by #125
Assignees
@DanSallau
Labels
🐛 Bug Something isn't working 🚀 Release
Projects
React Components
Milestone
April Release

Comments

@DanSallau
Copy link
Contributor

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
At the moment, out accordion doesn't allow user to set the active item among the lists and i believe it should.
Expected behavior
When the props activeIndex is set , the accordion should set the item as active and expand or collapse it.
@DanSallau DanSallau added the 🐛 Bug Something isn't working label Feb 13, 2020
@DanSallau DanSallau added this to the February Release milestone Feb 13, 2020
@DanSallau DanSallau self-assigned this Feb 13, 2020
@DanSallau DanSallau added this to To do in React Components via automation Feb 13, 2020
DanSallau pushed a commit that referenced this issue Feb 13, 2020
fix(accordion): fixes #124
09459c2
@DanSallau DanSallau mentioned this issue Feb 13, 2020
Merged
React Components automation moved this from To do to Done Feb 25, 2020
DanSallau added a commit that referenced this issue Feb 25, 2020
@DanSallau
Merge pull request #125 from sebgroup/bug/accordion-default-active
bad3c22 
fix(accordion): fixes #124
@sebopensource
Copy link

🎉 This issue has been resolved in version 3.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DanSallau DanSallau

Labels
🐛 Bug Something isn't working 🚀 Release
Projects
React Components
  
Done
Milestone
April Release
Development

Successfully merging a pull request may close this issue.

fix(accordion): fixes #124 seb-oss/react-components
2 participants
@DanSallau @sebopensource