Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace disposal delay with Handler post mechanism to detect Activity resume #32

Merged
merged 5 commits into from
Oct 8, 2023

Conversation

sebaslogen
Copy link
Owner

@sebaslogen sebaslogen commented Oct 7, 2023

See original discussion #5

Thanks to these two articles below I could build a mechanism to reliably detect Composables that are disposed of and come back (or not) after Activity recreation
https://blog.p-y.wtf/whilesubscribed5000
https://developer.squareup.com/blog/a-journey-on-the-android-main-thread-lifecycle-bits/

TODO

  • Move Activity recreation tests to Espresso, Robolectric lifecycle seems to not match the one on a real Android
  • Clean up logs
  • Update readme

@sebaslogen sebaslogen merged commit 321367a into main Oct 8, 2023
2 checks passed
@sebaslogen sebaslogen deleted the feature/post-refactor branch October 8, 2023 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant