Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement missing imps for Target #6

Closed
7 tasks
sebasmagri opened this issue Aug 19, 2017 · 2 comments
Closed
7 tasks

Implement missing imps for Target #6

sebasmagri opened this issue Aug 19, 2017 · 2 comments

Comments

@sebasmagri
Copy link
Collaborator

Target is missing the following traits:

  • Clone
  • Copy
  • Eq
  • PartialEq
  • Ord
  • PartialOrd
  • Hash
@sebasmagri sebasmagri mentioned this issue Aug 19, 2017
Closed
9 tasks
@mjkillough mjkillough mentioned this issue Aug 22, 2017
Merged
@KodrAus
Copy link
Collaborator

KodrAus commented Aug 27, 2017

Do you think Ord + PartialOrd makes sense for Target? I'm not sure what a reasonable ordering would look like.

@mjkillough
Copy link
Contributor

Do you think Ord + PartialOrd makes sense for Target? I'm not sure what a reasonable ordering would look like.

Agreed. I've removed them from my PR #18.

KodrAus pushed a commit that referenced this issue Sep 1, 2017
@mjkillough @KodrAus
Derive std traits for Target. (#18)
5451f90 
* Derive std traits for Target.

Fixes #6.

* Ord and PartialOrd not appropriate for Target.
epage added a commit that referenced this issue Oct 6, 2023
@epage
Merge pull request #6 from peter-kehl/readme_use_crates_io_link_place…
8499939 
…holder

README.md 'Crates Status' icon link
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sebasmagri @mjkillough @KodrAus