Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use async code to download files #3

Open
sebasmonia opened this issue Jun 6, 2018 · 1 comment
Open

Use async code to download files #3

sebasmonia opened this issue Jun 6, 2018 · 1 comment
Labels
enhancement New feature or request
Milestone

Comments

@sebasmonia
Copy link
Owner

sebasmonia commented Jun 6, 2018

Currently to download a file I use a sync call.
As per suggestions received in the emacs subreddit, I could add a small delay accepting output before considering the file (or any output) done.

As a bonus I could make the delay configurable, based on my experience of TFS being in a remote location being really slow.

This would impact regular commands too. Everything would benefit from the change in logic. Right now async commands just run with no end in sight. Most of them complete pretty quickly though.

@sebasmonia sebasmonia self-assigned this Jun 8, 2018
@sebasmonia sebasmonia added the enhancement New feature or request label Jun 8, 2018
@sebasmonia sebasmonia removed their assignment Jun 13, 2018
@sebasmonia
Copy link
Owner Author

After the merge of waitforoutput I decided to let the files continue being sync for now.

Async commands run faster but the printing part has a few additional challenges. I think shelves, labels and branching are more important now than making this faster.

@sebasmonia sebasmonia added this to the Version 2 milestone Jun 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant