Added mp4 and webp support to Giphy::Image #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The Travis CI build failed in the first commit because there's a bug in Bundler that causes it to throw an error when installing the bundle in older Ruby versions. According to this bug report (rubygems/bundler#3558) using the |
|
This resolves #18 |
|
@sebasoga Any chance this will get merged soon? |
|
Hey @lirien thanks for adding support for I'll cut a new version this weekend including these changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Giphy API now supports HTML5 video formats and they were previously not accessible without accessing the private
hashattribute. This pull request makes them accessible in theGiphy::Imageclass.