Catch-up to master #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- files created on update() - no errors when removing source photo - hash dropped from album.yml when removing source photo - clean removes all output files
…PhotoSwipe into sebastiaan-lampo-album-test
This may be a coding style issue, but I generally don't think these are needed as tests/ is not a module.
- $ from the beginning of code blocks where they were there by mistake - changed lists of files to be vertical instead of horizontal (easier to read) or used tree to display complete structure. - I assume in the section about copying files from PhotoSwipe repo you intended for the image files to be included along with CSS and JS so that's what is written - made one tiny content change in "Adding our first album" to clarify something that tripped me up. See #38
…oPhotoSwipe into CouldBeThis-wiki-edits-minor
|
Re-basing edits on the updated master in code editor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.