Skip to content
This repository has been archived by the owner on Nov 1, 2021. It is now read-only.

Fix top scorers for excluded leagues #36

Closed
sebastiaanspeck opened this issue Oct 16, 2018 · 6 comments · Fixed by #46
Closed

Fix top scorers for excluded leagues #36

sebastiaanspeck opened this issue Oct 16, 2018 · 6 comments · Fixed by #46
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest Hacktoberfest
Milestone

Comments

@sebastiaanspeck
Copy link
Owner

Is your feature request related to a problem? Please describe.
Right now the top scorers are not shown for World Cup.
At this moment this is no issue for Champions League and Europa League, but this will become an issue when those tournaments reach knock-out phase

Describe the solution you'd like
Show the top scorers for the World Cup (not only the final but the whole tournament)

Additional context
I think we need to use aggregated endpoint here:
$soccerAPI->topscorers()->setInclude($includeTopscorersAggregated)->aggregatedBySeasonId($league->current_season_id)->aggregatedGoalscorers->data;

@sebastiaanspeck sebastiaanspeck added this to the Version 2 milestone Oct 16, 2018
@sebastiaanspeck sebastiaanspeck added enhancement New feature or request good first issue Good for newcomers hacktoberfest Hacktoberfest labels Oct 16, 2018
@Visovsiouk
Copy link
Contributor

Can I tackle this issue?

@sebastiaanspeck
Copy link
Owner Author

Go ahead and try!

@Visovsiouk
Copy link
Contributor

This cannot be tested with the basic sportsmonks API Plan

@sebastiaanspeck
Copy link
Owner Author

I can create an API key for you. Give me your mailadress and I will mail you the API key so you can test it.

@Visovsiouk
Copy link
Contributor

Thank you. My email:
visovsiouk@gmail.com

@sebastiaanspeck
Copy link
Owner Author

Still not what I want.. I will try to contact the API-supplier to ask if they know a solution

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest Hacktoberfest
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants