Skip to content
This repository has been archived by the owner on Nov 1, 2021. It is now read-only.

Add top scorers #51

Open
sebastiaanspeck opened this issue Oct 20, 2018 · 0 comments
Open

Add top scorers #51

sebastiaanspeck opened this issue Oct 20, 2018 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Milestone

Comments

@sebastiaanspeck
Copy link
Owner

sebastiaanspeck commented Oct 20, 2018

Is your feature request related to a problem? Please describe.
I want to show the top-10 top scorers for all leagues.

Describe the solution you'd like
Some leagues don't have topscorers-coverage (mostly cups), to determine this, you can view it using
$league->coverage->topscorer_goals and if it returns false, there is no topscorers-coverage

Some leagues are cups, but do have topscorers-coverage (like Champions League). For these leagues I only want the topscorers for the group-stage and the knock-out afterwards, so exclude the qualifying topscorers.

Some leagues are no cups and do have topscorers-coverage (mostly competitions like Premier League). For those leagues I only want the topscorers from the Regular Season-stage.

Look in the API-docs for more information about the endpoints. If you want to use the aggregatedTopscorers, copy the folder to vendor/kirill-latish.

Test your solution with the next leagues:

  • Pro League or Eredivisie
  • Premier League
  • FA Cup (or any other cup) -> this one doesn't need to show any top scorers
  • World Cup -> show the aggregated top scorers
  • Champions League/Europa League -> show the aggregated top scorers, but leave out the top scorers from the qualifications-rounds

Preferably I don't want to have hardcoded the leagues that use specific cases. I want a dynamic solution, so that if we add more leagues later on, this issue doesn't reappears.

Describe alternatives you've considered
#36 #46

We tried several things, but the ultimate solution hasn't been found yet.

Additional context

  • I contacted the API-supplier for a solution, but I am still awaiting their reaction.
  • If you want to take this issue, comment with your email, I will create and send you an API-token to test your solution.
@sebastiaanspeck sebastiaanspeck added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers hacktoberfest Hacktoberfest labels Oct 20, 2018
@sebastiaanspeck sebastiaanspeck added this to the Version 2 milestone Oct 24, 2018
@sebastiaanspeck sebastiaanspeck removed the hacktoberfest Hacktoberfest label Jan 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant