This repository has been archived by the owner on Nov 1, 2021. It is now read-only.
Add top scorers #51
Labels
enhancement
New feature or request
good first issue
Good for newcomers
help wanted
Extra attention is needed
Milestone
Is your feature request related to a problem? Please describe.
I want to show the top-10 top scorers for all leagues.
Describe the solution you'd like
Some leagues don't have topscorers-coverage (mostly cups), to determine this, you can view it using
$league->coverage->topscorer_goals
and if it returns false, there is no topscorers-coverageSome leagues are cups, but do have topscorers-coverage (like Champions League). For these leagues I only want the topscorers for the group-stage and the knock-out afterwards, so exclude the qualifying topscorers.
Some leagues are no cups and do have topscorers-coverage (mostly competitions like Premier League). For those leagues I only want the topscorers from the Regular Season-stage.
Look in the API-docs for more information about the endpoints. If you want to use the aggregatedTopscorers, copy the folder to vendor/kirill-latish.
Test your solution with the next leagues:
Preferably I don't want to have hardcoded the leagues that use specific cases. I want a dynamic solution, so that if we add more leagues later on, this issue doesn't reappears.
Describe alternatives you've considered
#36 #46
We tried several things, but the ultimate solution hasn't been found yet.
Additional context
The text was updated successfully, but these errors were encountered: