Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of build warnings related to monoids #190

Closed
turion opened this issue Nov 17, 2019 · 3 comments
Closed

Get rid of build warnings related to monoids #190

turion opened this issue Nov 17, 2019 · 3 comments

Comments

@turion
Copy link
Collaborator

turion commented Nov 17, 2019

When building with GHC 8.8, There are a lot of warnings like this:

The import of ‘Data.Semigroup’ is redundant

These places should be refactored to make build less noisy.

@Temurson
Copy link
Contributor

Temurson commented Nov 27, 2019

Hello! I would love to fix this. Currently, I have cloned the repo and managed to build the project. I got the same warnings. I will try to make a PR soon (if I figure out how to do this).
Should I only fix warnings about Data.Semigroup? Only -Wunused-imports? All of them?

@turion
Copy link
Collaborator Author

turion commented Nov 28, 2019

@Temurson thanks for your enthusiasm, but this issue was already fixed in #192. There are lots of other open issues, though ;)

@turion turion closed this as completed Nov 28, 2019
@turion
Copy link
Collaborator Author

turion commented Nov 28, 2019

If you need any help making a PR, I'll gladly assist!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants