Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small bug in BaseModelForm #41

Closed
GoogleCodeExporter opened this issue May 6, 2015 · 3 comments
Closed

Small bug in BaseModelForm #41

GoogleCodeExporter opened this issue May 6, 2015 · 3 comments

Comments

@GoogleCodeExporter
Copy link

What steps will reproduce the problem?
1. try to initialize djangoforms.BaseModelForm with existing model instance

What is the expected output? What do you see instead?
The data attribute in the dictionary for forms.BaseModel should be set
with object_data - but that never happens.

Please provide any additional information below.
Just fix the line in the BaseModelForm constructor
    kwargs = dict(data=data ...
with
    kwargs = dict(data=object_data ...

Original issue reported on code.google.com by constant...@gmail.com on 12 Jun 2008 at 8:55

@GoogleCodeExporter
Copy link
Author

Which file are you referring to?

The Django helper does not ship a BaseModelForm class.

Perhaps you meant to file this bug on the Appengine SDK rather than the Django 
helper?

Original comment by mattbrow...@gmail.com on 24 Jun 2008 at 10:54

  • Added labels: Priority-Low
  • Removed labels: Priority-Medium

@GoogleCodeExporter
Copy link
Author

Yes you are right - I meant app engine sdk
But what I have observed is actually no bug - and do not fix it like I suggested
because this would lead into actually buggy behavior :)
I don't know how to close this issue otherwise I would have closed it already.

The problem I actually observed is: you cannot use BaseModelForm providing data 
and
instance together. If you do so and the POST/GET data is empty the form will be 
empty
too - although it should be filled with the instance's data.

That seems odd but the issue I described doesn't help here for sure.

Sorry for your inconvenience.
Regards,
Constantin

Original comment by constant...@gmail.com on 25 Jun 2008 at 6:58

@GoogleCodeExporter
Copy link
Author

Original comment by mattbrow...@gmail.com on 26 Jun 2008 at 9:31

  • Changed state: Invalid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant