Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for quests in party #353

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

pacampbell
Copy link
Collaborator

@pacampbell pacampbell commented Jun 19, 2024

  • Party list updates with proper progress.
  • Track completion of world quests.
  • Add a new column to track number of times a quest is completed.
  • Treat quest accept as a checkpoint for saving progress.
  • Fix issue where shallow copy didn't really shallow copy in the quest structure.
  • Fix issue where changing additional members of quest structure on accident.

Migration Scripts

CREATE TABLE IF NOT EXISTS "ddon_priority_quests" (
	"character_common_id"	INTEGER NOT NULL,
	"quest_id"	INTEGER NOT NULL,
	FOREIGN KEY("character_common_id") REFERENCES "ddon_character_common"("character_common_id") ON DELETE CASCADE
);

Add a new column to the ddon_completed_quests called clear_count

"clear_count"	INTEGER NOT NULL DEFAULT 0

Remove primary key constraint from ddon_quest_progress for character_common_id which was added by mistake.

Checklist:

  • The project compiles
  • The PR targets develop branch

@pacampbell pacampbell force-pushed the add_quest_party_support branch 9 times, most recently from 962eb44 to c618329 Compare June 20, 2024 14:01
- Party list updates with proper progress.
- Track completion of world quests.
- Treat quest accept as a checkpoint for saving progress.
- Fix issue where shallow copy didn't really shallow copy in the quest
  structure.
- Fix issue where changing additional members of quest structure on accident.
- Added checkpoints to 1.0 MSQ.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant