-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Investigate Blitterblack Maze #363
Draft
pacampbell
wants to merge
11
commits into
sebastian-heinz:develop
Choose a base branch
from
pacampbell:bitter_black_isle
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enabled warp from cave harbour to Bitterblack Maze.
- Added support for BattleContentGetContentStatusFromOm Req/Res - Added partial decoding for S2CBattleContentInfoListRes - Need to implement decoding for final part (large list of numbers)
- Added new packet handler for BattleContentContentEntryHandler - Continued to work decoding the contents of S2CBattleContentInfoListRes and S2CBattleContentContentEntryNtc. There seems to be an issue with the Unk4 and Unk5 fields in S2CBattleContentInfoListRes.
Fixed an issue where the fields for S2CBattleContentContentEntryNtc and S2CBattleContentInfoListRes were encoded incorrectly.
Created BattleContentInstantClearInfoHandler to handle clear info packets.
Added new packets C2SBattleContentPartyMemberInfoUpdateReq, S2CBattleContentPartyMemberInfoUpdateRes and S2CBattleContentPartyMemberInfoUpdateNtc. The client seems to be stuck in a loop requesting this packet over and over so probably some more fields need to be filled out.
Added some monsters to 2 maps. Used Freddy to warp to the maze from WDT.
- Fixed an issue where CDataBattleContentUnk4 didn't have an read/write serializer implementation. - Played around with more values in the packet responses.
Added a enum which represents the current mode of the game.
bc76cdc
to
75258f3
Compare
Added more packets and annotated some fields based on some guesses.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabled warp to/from Cave Harbor to Bitterblack Maze.
Warning
Nothing works after entering. Need to support new packets.
Checklist:
develop
branch